Uploaded image for project: 'vpp'
  1. vpp
  2. VPP-570

Fix coverity error in lib-vxlan-gpe

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Done
    • Icon: Medium Medium
    • 17.01
    • None
    • None
    • None

      And please double-commit it to stable/1701.

      Thanks,

      Damjan

      > On 23 Dec 2016, at 13:54, Dave Barach (dbarach) <dbarach@cisco.com> wrote:
      >
      > Please deal with this warning AYEC.
      >
      > I suspect that the so-called bug is actually "intentional, not a bug;" you can dismiss it in the Coverity GUI if that's correct.
      >
      > The easiest way to find the GUI: google "fd.io vpp coverity"...
      >
      > Thanks... Dave
      >
      > ----Original Message----
      > From: scan-admin@coverity.com scan-admin@coverity.com
      > Sent: Friday, December 23, 2016 7:35 AM
      > To: github@barachs.net
      > Subject: New Defects reported by Coverity Scan for fd.io VPP
      >
      >
      > Hi,
      >
      > Please find the latest report on new defect(s) introduced to fd.io VPP found with Coverity Scan.
      >
      > 1 new defect(s) introduced to fd.io VPP found with Coverity Scan.
      > 2 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.
      >
      > New defect(s) Reported-by: Coverity Scan Showing 1 of 1 defect(s)
      >
      >
      > ** CID 158977: Uninitialized variables (UNINIT)
      > /plugins/ioam-plugin/ioam/lib-vxlan-gpe/vxlan_gpe_test.c: 520 in
      > api_vxlan_gpe_ioam_transit_disable()
      >
      >
      > ______________________________________________________________________
      > __________________________________
      > *** CID 158977: Uninitialized variables (UNINIT)
      > /plugins/ioam-plugin/ioam/lib-vxlan-gpe/vxlan_gpe_test.c: 520 in api_vxlan_gpe_ioam_transit_disable()
      > 514 }
      > 515 else
      > 516

      { > 517 clib_memcpy (&mp->dst_addr, &local4, sizeof (local4)); > 518 }

      > 519
      >>>> CID 158977: Uninitialized variables (UNINIT)
      >>>> Using uninitialized value "outer_fib_index" when calling "htonl".
      > 520 mp->outer_fib_index = htonl (outer_fib_index);
      > 521 mp->is_ipv6 = ipv6_set;
      > 522
      > 523 S;
      > 524 W;
      > 525
      >
      >
      > ______________________________________________________________________
      > __________________________________
      > To view the defects in Coverity Scan visit,
      > https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2B
      > fV0V05UPxvVjWch-2Bd2MGckcRYcW79rMZuThOa0wxQ6-2FHiruLDCbPlsfl4aW7zDutVD
      > LNUk-2Fn8IAhF0V1zDhPZkckQ-3D_-2FVROoU4I00kED-2Ftre1IeplOlw0Wx6i-2Bvbek
      > dFo-2FjmkwZ-2BrDZnpaub7VujYGRaeh0gtZylxoxS8AKf0FmZnGubfNzaL0LD45YzHJjJ
      > ZlA5yU0spSh5aNrcIFZ-2Fls6pQVc3bmZbfRf2fviK-2F-2FQKX1W7qXz8EDwczKSBXmZM
      > HMgIs7CE4GM-2Bo-2ByzwwWmq-2FWnpOAEzb6KL1d8Y-2FQjcGZ-2BPTk6bqK9gpjXGgh-
      > 2Fwu-2BEDspgio-3D
      >
      > To manage Coverity Scan email notifications for "github@barachs.net",
      > click
      > https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2B
      > fV0V05UPxvVjWch-2Bd2MGckcRbVDbis712qZDP-2FA8y06Nq4oPb6EtnbLsRJjDrRsBie
      > juF-2FKwAGMFzbQe4eZZvdygmcjrwu0oQb5LMoEG1CQO6Tzp6b8iOAPP0sR-2BLlJvMgIi
      > BnxDn0Qbu9zsI7GIEnZ9A-3D_2FVROoU4I00kED-2Ftre1IeplOlw0Wx6i-2BvbekdFo
      > 2FjmkwZ-2BrDZnpaub7VujYGRaeh0sF1ckDlDPB9irfrjpnbmxZXpS6Wcl-2Ba2cggd4zW
      > K1qBK-2FiAZI0QoIhteML0O2agJ2qwQlj4iR3d3rjjcKDK089otNf2-2Bcm1iUZs19g5CR
      > 3S3HWNzH2abWi9wqaN4tz-2FaFfgnsQ-2F-2FkUIxKJ8zDKCWYbB2Jp0-2FswkujQk3QIA
      > ToNM-3D
      >

            venggovi Vengada Govindan
            venggovi Vengada Govindan
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: